Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bun/ws): fix invalid types #3562

Merged
merged 1 commit into from
Oct 27, 2024
Merged

Conversation

nakasyou
Copy link
Contributor

Fixes #3553

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

Copy link

codecov bot commented Oct 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.71%. Comparing base (7e11832) to head (7799dd8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3562   +/-   ##
=======================================
  Coverage   94.71%   94.71%           
=======================================
  Files         157      157           
  Lines        9539     9539           
  Branches     2819     2795   -24     
=======================================
  Hits         9035     9035           
  Misses        504      504           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

Thanks @nakasyou !

@yusukebe yusukebe merged commit f55dc45 into honojs:main Oct 27, 2024
16 checks passed
@nakasyou nakasyou deleted the fix/bun-ws-types branch October 27, 2024 06:51
TinsFox pushed a commit to TinsFox/hono that referenced this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hono Websocket with bun
2 participants