-
-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(service-worker): bind fetch to globalThis
#3500
fix(service-worker): bind fetch to globalThis
#3500
Conversation
Hi @sapphi-red Thanks! I'll check it later. |
Hi @sapphi-red Thank you for the PR.
I think it's good to use the mocks.
Exactly. If we decide to add it, we can put it into the I've left one comment. Please check it! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3500 +/- ##
=======================================
Coverage 95.58% 95.58%
=======================================
Files 155 155
Lines 9357 9357
Branches 2730 2761 +31
=======================================
Hits 8944 8944
Misses 413 413 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Looks good to me! Thank you for your contribution. I'll merge this and release a new version. |
* fix(service-worker): bind fetch to `globalThis` * chore: ignore lint error
This PR fixes #3176 correctly. It was not working with #3200.
I added a test but it's full of mocks and probably not much useful. Feel free to remove it 😅
Ideally an e2e test is needed.
The author should do the following, if applicable
bun run format:fix && bun run lint:fix
to format the code