Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(path): remove unnecessary slashes #3401

Closed
wants to merge 1 commit into from

Conversation

ryuapp
Copy link
Contributor

@ryuapp ryuapp commented Sep 9, 2024

Fix denoland/deno#25532

This is a Deno compatibility issue. However we can fix it here.
It would be better if it could be bound by rules.

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.77%. Comparing base (f9a23a9) to head (502a554).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3401   +/-   ##
=======================================
  Coverage   95.77%   95.77%           
=======================================
  Files         152      152           
  Lines        9187     9187           
  Branches     2788     2709   -79     
=======================================
  Hits         8799     8799           
  Misses        388      388           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ryuapp
Copy link
Contributor Author

ryuapp commented Sep 9, 2024

Oops. The issue seems to be a problem that cannot be fixed here , so I will temporarily close this PR.
If I have any other ideas, I will open the pr again.

@ryuapp ryuapp closed this Sep 9, 2024
@ryuapp ryuapp deleted the fix-path-for-deno branch September 9, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module resolution doesn't work correctly when the module specifier includes double slashes //
1 participant