Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bearer-auth): added custom response message options #3372

Merged

Conversation

marceloverdijk
Copy link
Contributor

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.77%. Comparing base (3500404) to head (3817ad6).
Report is 14 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3372      +/-   ##
==========================================
- Coverage   95.77%   95.77%   -0.01%     
==========================================
  Files         152      152              
  Lines        9187     9207      +20     
  Branches     2818     2758      -60     
==========================================
+ Hits         8799     8818      +19     
- Misses        388      389       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marceloverdijk
Copy link
Contributor Author

@yusukebe here is the alternative PR: #3381

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

@marceloverdijk

Thanks! Looks good to me. I'll merge this into the next later. Appreciate your contribution!

@yusukebe yusukebe changed the base branch from main to next September 11, 2024 02:08
@yusukebe yusukebe merged commit c240ea5 into honojs:next Sep 11, 2024
14 checks passed
@yusukebe yusukebe mentioned this pull request Sep 11, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants