-
-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pretty-json): support custom query #3300
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3300 +/- ##
=======================================
Coverage 96.31% 96.31%
=======================================
Files 151 151
Lines 15368 15378 +10
Branches 2683 2702 +19
=======================================
+ Hits 14801 14811 +10
Misses 567 567 ☔ View full report in Codecov by Sentry. |
This is a cool improvement! I've left a comment. |
@yusukebe Thank you for reviewing. I changed it, so please check it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks! Looks good. Not sure whether to include it in the next minor version or in the patch version. After considered, I'll merge it. |
Hey @nakasyou I've decided to include this feature in the next patch release (I can't wait for the next minor release!). Merging now. Thank you! |
Pretty JSON middleware changed to support custom queries, like that:
In this case, you can see formatted JSON at
?format
. I think it should be customizable.The author should do the following, if applicable
bun run format:fix && bun run lint:fix
to format the code