feat(jsx/dom): introduce react-dom/client APIs and React.version #2795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yusukebe How about including this in v4.4? |
yusukebe
reviewed
May 26, 2024
Nice! Let's include this. |
|
One thing. Please update the |
|
I'm fixing it, just give me a minute. |
|
Sorry I'm late, fixed. 2e0dbca |
|
Thank you! Now, I'll merge this into the next. The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2792
version
There seems to be a library that does conditional branching on the major version number of
React.version.This is like a UserAgent of a web browser (e.g. Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/125.0.0.0 Safari/537. 36), which is a string for compatibility and somewhat unpleasant to use, and we do not recommend its use, but if this improves compatibility, it should be added.
createRoot / hydrateRoot
Some options are not yet supported, but they can be rendered in the way recommended by React since version 18, as shown in the following diff.
usualoma/hono-react-compat-demo@3877355
The author should do the following, if applicable
bun run format:fix && bun run lint:fixto format the code