feat(jsr): remove helper.ts and middleware.ts #2667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You are right. We can remove them. Thanks! |
yusukebe
added a commit
that referenced
this pull request
May 24, 2024
* feat(jsr): reduce slow types (#2369) * feat(jsr): reduce slow types * fix: use allow function * chore: format code * chore: denoify * add `deno.json` * add `jsr-dry-run` command for CI * don't put `JSX` on `global` * fix test settings for deno * don't use `dynamicClass` * don't declare `ExecutionContext` in `global` * goodbye denoify * exports `./middleware` * exports `./helper` * exports each helper and middleware * remove the `awslambda` implementation which is not enough * feat(jsr): remove helper.ts and middleware.ts (#2667) * feat(jsr): remove helper.ts and middleware.ts * fix: fix test * dont' use `SuperClass` Co-authored-by: Taku Amano <[email protected]> * feat(jsr): delete `mod.ts` (#2669) * rename `deno.json` to `jsr.json` * lint * remove slow type in lambda adapter * fixed runtime test for deno * export all utils * add a GitHub action to publish the package to JSR * fixed declaring `ContextVariableMap` * fixed the type error * include `jsr.json` in `jsr.json` * update `jsr.json` --------- Co-authored-by: Shotaro Nakamura <[email protected]> Co-authored-by: Taku Amano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
feat/jsr, denoify has removed.exports field of npm and jsr don't have reference to
helper.tsandmiddleware.ts, so these files should be removed.The author should do the following, if applicable
bun denoifyto generate files for Denobun run format:fix && bun run lint:fixto format the code