Reduce canvas width for Firefox WebGL support #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firefox's WebGL "Max Texture Size" is 8192, lower than the 10 ** 4 that was being created. This caused the imagery to render with no colors (all black). I'm not exactly sure why (I'd expect it to not render at all).
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@TheMrCam Thank you, this is the first PR for this repository. A new version that fixes this issue has been released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Reduces the
plottycanvas width to 8192, the maximum limit for Firefox's WebGL implementation.With the current value of 10000--while using Firefox--TIFFs render every pixel value as black.
There are no visible issues in Safari or Microsoft Edge, with max texture size of 16384.
This change resolves #31, see that issue for more details.
Side effects?
Disclaimer:
I did not check for wide-reaching side effects (in any browser) after making this change, just that the color showed up as expected in Firefox.