Skip to content

Conversation

@chelsea-bd
Copy link

Completed expected changes and Fixes

  • Removed version: '3.8' (not needed).
  • Renamed host network to custom_network to prevent conflicts.
  • Ensured IPv4 addressing works by using a custom bridge network.
  • Added a health check for dicomhawk to ensure it is fully ready before logserver starts.

Further alterations

  • .env file created to store environment variables to prevent hardcoding and ensure enhanced security. referenced as ${VARIABLE_NAME} in docker-compose.yml
  • added a .gitignore file to ignore .env when commits are made to avoid sensitive data being committed
  • altered Ip port in dicomhaw.py to “0.0.0.0” when the server starts to ensure all ip adresses are accesses

Testing

  • docker-compose —build -d successfully ran without any network conflicts
  • enviroment variables are being passed correctly in containers when env | grep ENABLE_LOGGING is passed
  • container status healthy when command i.e docker inspect --format='{{json .State.Health}}' are passed

@chelsea-bd chelsea-bd changed the title chelsea baird-docker.yml update docker-compose.yml update Mar 11, 2025
@chelsea-bd chelsea-bd changed the title docker-compose.yml update docker-compose.yml update #20 Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant