This repository was archived by the owner on Aug 13, 2025. It is now read-only.
Update aspnetcore instrumentation to 1.0.0-rc9.9 #319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeGoldsmith
added
type: maintenance
cartermp
approved these changes
Nov 15, 2022
Contributor
cartermp
left a comment
cartermp
left a comment
There was a problem hiding this comment.
Looks good pending smoke tests
Contributor
|
Blocked by #320 |
MikeGoldsmith
pushed a commit
that referenced
this pull request
Nov 15, 2022
## Which problem is this PR solving? When upgrading autoinstrumentation versions to rc9.9, the `OTEL_METRIC_EXPORT_INTERVAL` is supported and our smoke tests export interval is too short (100ms, we're checking for results every 1s) which causes smoke tests to fail. This PR removes the unused env variable. - Unblocks #319 & #318 ## Short description of the changes - Removes `OTEL_METRIC_EXPORT_INTERVAL` option set in the smoke tests docker-compose.yml - Adds `--build` option to smoke tests docker-compose step since without rebuilding it's hard to figure out if you're working with a previously cached build.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Bumps AspNetCore instrumentation to latest and updates the enrich usage.
Short description of the changes