fix: check parent exists during instrumentation: (#525)

Co-authored-by: Mike Goldsmth <[email protected]>
honeycombio · Jan 6, 2022 · cdd32ad · cdd32ad
1 parent e426fce
commit cdd32ad
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/lib/instrumentation.js b/lib/instrumentation.js
@@ -71,7 +71,7 @@ function getPackageVersion(request, options) {
 }
 
 const instrumentLoad = (exports.instrumentLoad = (mod, loadRequest, parent, opts = {}) => {
-  if (parent.id.includes(`node_modules/${pkg.name}`) || !enabledInstrumentations.has(loadRequest)) {
+  if (!parent || parent.id.includes(`node_modules/${pkg.name}`) || !enabledInstrumentations.has(loadRequest)) {
     // no magic here
     return mod;
   }

diff --git a/lib/instrumentation.test.js b/lib/instrumentation.test.js
@@ -102,3 +102,11 @@ test("we keep track of the active instrumentations in a sorted array", () => {
   // activeInstrumentations now includes child_process
   expect(instrumentation.activeInstrumentations()).toEqual(["child_process", "express"]);
 });
+
+test("don't instrument module if parent is null", () => {
+  instrumentation.clearInstrumentationForTesting();
+  let fakeExpress = createFakeExpress();
+  let m = instrumentation.instrumentLoad(fakeExpress, "express", null);
+  expect(m).toBe(fakeExpress);
+  expect(m.__wrapped).toBeUndefined();
+});