Bump go.opentelemetry.io/otel from 0.18.0 to 0.19.0#208
Conversation
Bumps [go.opentelemetry.io/otel](https://github.com/open-telemetry/opentelemetry-go) from 0.18.0 to 0.19.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go@v0.18.0...v0.19.0) Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
the
type: maintenance
| } | ||
| ctx = trace.ContextWithSpan(ctx, otelSpan) | ||
| propagator := b3.B3{} | ||
| propagator := b3.B3{InjectEncoding: b3.B3MultipleHeader} |
There was a problem hiding this comment.
OTEL changed default behavior when no encoding provided to create a single B3 header: open-telemetry/opentelemetry-go-contrib#614
There was a problem hiding this comment.
Do I understand this correctly?
Previously the B3MultipleHeader would be used by default, but now the default is an B3Unspecified? So we're injecting explicitly the previous default?
There was a problem hiding this comment.
If unspecified, it used to make it a multi-header. Now if unspecified, it makes it a single-header.
There was a problem hiding this comment.
OK. So this is us saying multi-header all the time?
There was a problem hiding this comment.
Correct -- that's keeping it in sync with our existing API. Without this change we would inherit the "new default" which would be a breaking change for our users.
There was a problem hiding this comment.
👍 Cool. Thank you for the explanation!
| ctx = propagator.Extract(ctx, supp) | ||
| spanContext := trace.RemoteSpanContextFromContext(ctx) | ||
| prop := &PropagationContext{ | ||
| TraceID: spanContext.TraceID.String(), |
There was a problem hiding this comment.
paulosman
left a comment
paulosman
left a comment
There was a problem hiding this comment.
Nice. Really appreciate the link to OTel issues describing changes where possible.
vreynolds
deleted the
dependabot/go_modules/go.opentelemetry.io/otel-0.19.0
branch
4 participants
Bumps go.opentelemetry.io/otel from 0.18.0 to 0.19.0.
Release notes
Sourced from go.opentelemetry.io/otel's releases.
... (truncated)
Changelog
Sourced from go.opentelemetry.io/otel's changelog.
Commits
2b4fa96Release v0.19.0 (#1710)4beb704sdk/trace: removing ApplyConfig and Config (#1693)1d42be1Rename WithDefaultSampler TracerProvider option to WithSampler and update doc...860d5d8Add flag to determine whether SpanContext is remote (#1701)0fe65e6Comply with OpenTelemetry attributes specification (#1703)8888435Bump google.golang.org/api from 0.40.0 to 0.41.0 in /exporters/trace/jaeger (...345f264breaking(zipkin): removes servicName from zipkin exporter. (#1697)62cbf0fPopulate Jaeger's Span.Process from Resource (#1673)28eaaa9Add a test to prove the Tracer is safe for concurrent calls (#1665)8b1be11Rename resource pkg label vars and methods (#1692)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)