Remove deepcopy #173
Merged
Remove deepcopy #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuap
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
I'm lacking context on the substance of this change tbh, so it would be nice if @Kelvin4664 or @subzero10 could also review.
|
Also, i believe directly reverting that PR will be a better approach here. I have opened #174 for that. Someone take a look before i merge. |
|
I think it makes sense to keep the removal of keys that are tuples, but the way that it was done could be improved (this PR), so I'm going to go with this to fix the issue, and we can revisit if necessary. |
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #172