-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore 🧹: PEP8 linting #149
Conversation
- autopep8 --max-line-length=127 --in-place --recursive .
- flake8-3.11 . --exclude=.venv,.eggs --max-line-length=127 --statistics --count
This reverts commit af99987.
Cool! How do we make sure that all new code has gone through a linter before pushing to main branch? |
I was about to create a 2nd github action, as I've done this before with flake8. But just now, I finally got tox performing the entire CI/tests. And from what I've learned, it will be a synch to add linting too. See upcoming PR... |
So the first step is to approve this chore PR. That way the code conforms to some basic level of PEP8. Then we can begin auto-linting. I've definitely got ideas/examples in that realm too... |
I initially approved, but then noticed that tests are failing 🤔 |
Those tests ran successfully previously, so the error is apparently unrelated.
And both Celery (and its dependency kombu) were just released recently. https://pypi.org/project/celery/#history Maybe we need a quick CI patch to pin those to older revs. |
Yep that was it. Back-hacked my new logic from here: I'll cherry-pick that commit into new PR too... |
Nice find, thanks! |
Simply ran
autopep8 --max-line-length=127 --in-place --recursive .