Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add local variables to notifications #123

Merged
merged 5 commits into from
Nov 11, 2022
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion honeybadger/payload.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
import traceback
import os
import logging
import inspect
from six.moves import range
from six.moves import zip
from io import open
Expand Down Expand Up @@ -107,6 +108,12 @@ def create_payload(exception, exc_traceback=None, config=None, context=None, fin
if exc_traceback is None:
exc_traceback = sys.exc_info()[2]

# try and get local variables from stacktrace
try:
local_variables = inspect.trace()[-1][0].f_locals
except Exception:
local_variables = None

#if context is None, Initialize as an emptty dict
if not context:
context = {}
Expand All @@ -119,7 +126,10 @@ def create_payload(exception, exc_traceback=None, config=None, context=None, fin
},
'error': error_payload(exception, exc_traceback, config, fingerprint),
'server': server_payload(config),
'request': {'context': context}
'request': {
'context': context,
'local_variables': local_variables
}
}

return default_plugin_manager.generate_payload(payload, config, context)
Expand Down
23 changes: 20 additions & 3 deletions honeybadger/tests/test_payload.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,15 @@
import os
import sys

from honeybadger.payload import error_payload
from honeybadger.payload import server_payload
from honeybadger.payload import (
create_payload,
error_payload,
server_payload
)
from honeybadger.config import Configuration

from mock import patch
from nose.tools import eq_, ok_
from nose.tools import eq_, ok_, assert_raises

# TODO: figure out how to run Django tests?

Expand Down Expand Up @@ -123,3 +126,17 @@ def test_psutil_is_optional():
with patch.dict(sys.modules, {'psutil':None}):
payload = server_payload(config)
eq_(payload['stats'], {})

def test_create_payload_with_local_variables():
config = Configuration()
with assert_raises(Exception):
test_local_variable = {"test": "var"}
exception = Exception('Test')
payload = create_payload(exception, config=config)
eq_(payload['request']['local_variables'], test_local_variable)

def test_create_payload_without_local_cvariables():
config = Configuration()
exception = Exception('Test')
payload = create_payload(exception, config=config)
eq_(payload['request']['local_variables'], None)