Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add support for nitter expandos #5560

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FlaminSarge
Copy link
Contributor

@FlaminSarge FlaminSarge commented Jan 23, 2025

Relevant issue:
Tested in browser: Chrome

This goes directly to the given nitter instance instead of using the existing twitter/x handling.
Only includes the 2 nitter instances that seem to allow embeds.

Remaining in draft until discussion on whether to even do this concludes.

@FlaminSarge FlaminSarge changed the title Add support for xcancel expandos Feature: Add support for xcancel expandos Jan 23, 2025
This goes directly to the given nitter instance instead of using the existing twitter/x handling.
Only includes the 2 nitter instances that seem to allow embeds.
@FlaminSarge
Copy link
Contributor Author

Not sure if this should even be included given how liable the hosting services are to break...

@FlaminSarge FlaminSarge changed the title Feature: Add support for xcancel expandos Feature: Add support for nitter expandos Jan 23, 2025
@benmcgarry
Copy link
Collaborator

Not entirely against it, but with everything happening on Reddit right now im wary of flooding an endpoint with requests (we've done this before and got blocked) - How stable is this?

@FlaminSarge
Copy link
Contributor Author

How stable is this?

From my understanding: not stable at all at the moment. privacydev.net returns 429s after like the 2nd request, and poast.org load-loops. If xcancel or lightbrd were on board, those would be better, but they don't allow being used in iframes at all in their CSP.
Other instances: https://github.com/zedeus/nitter/wiki/Instances

However, under the assumption that folks will move away from Twitter links and at worst use these alternatives, it helps to be prepared with this draft PR.

@benmcgarry
Copy link
Collaborator

Yeah, Probably best to sit on this for a week or two and see if more appear that are stable and see how it goes. We have the release with Bluesky rolling out now so if this picks up we can quickly push one out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants