Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Colours #118

Open
georgejkaye opened this issue Nov 5, 2019 · 1 comment
Open

Colours #118

georgejkaye opened this issue Nov 5, 2019 · 1 comment
Assignees
@calintat

Comments

@georgejkaye
Copy link

Would be good if the colours chosen to represent new cells didn't clash with ones that already exist, as I managed to confuse myself by creating a diagram where several elements were all the same colour and I couldn't distinguish between them! Maybe even have an option to forbid the selection of colours manually if it already exists in the diagram (although for complicated diagrams you might have to double up at some point).

Also more colour presets would be nice!
@georgejkaye
Copy link
Author

I also can't seem to input full 6-digit hex colour codes when typing in the colour picker box, as typing three digits accepts it as a the 3-digit version (e.g. #123 becomes #112233). You can still paste in full 6-digit codes and have the box accept them.

@calintat calintat self-assigned this Nov 12, 2019
calintat added a commit that referenced this issue Nov 13, 2019
@calintat
Fix colour picker hex input (#118)
b54e758 
I downgraded the react-color package to version 2.17.0 since
BlockPicker is broken in newer versions. Also I stopped hiding
the picker in onChangeComplete to allow 6-digit hex colour codes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@calintat calintat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@georgejkaye @calintat