Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

watch: Add support for different resources #197

Merged
merged 2 commits into from
Oct 10, 2019
Merged

Conversation

qu1queee
Copy link
Contributor

@qu1queee qu1queee commented Oct 8, 2019

This includes:

  • secrets
  • configmaps
  • CRDs

For the subcmd, this includes two new flags:

  • -r for specifying the resource
  • -c for specifying the CRD

For the -r flag:

  • Default behaviour will be to watch pods

For the -c flag:

  • User can specify the short name or the singular name
    of the resource.

Copy link
Member

@HeavyWombat HeavyWombat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice.

internal/cmd/watch.go Outdated Show resolved Hide resolved
pkg/havener/havener.go Outdated Show resolved Hide resolved
This includes:
- secrets
- configmaps
- CRDs

For the subcmd, this includes two new flags:
- `-r` for specifying the resource
- `-c` for specifying the CRD

For the `-r` flag:
- Default behaviour will be to watch `pods`

For the `-c` flag:
- User can specify the short name or the singular name
of the resource.
@qu1queee qu1queee force-pushed the qu1queee/custom_watch branch from 050daf9 to a0a45c6 Compare October 10, 2019 18:37
@qu1queee qu1queee force-pushed the qu1queee/custom_watch branch from a0a45c6 to 184de7a Compare October 10, 2019 19:01
@qu1queee qu1queee merged commit 7cfaee1 into develop Oct 10, 2019
@qu1queee qu1queee deleted the qu1queee/custom_watch branch October 10, 2019 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants