Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Info: Affacted by network family change in Node.js 18 : "IPv4" is now 4 ?? #945

Closed
Apollon77 opened this issue Apr 23, 2022 · 1 comment
Closed

Info: Affacted by network family change in Node.js 18 : "IPv4" is now 4 ?? #945

Apollon77 opened this issue Apr 23, 2022 · 1 comment
Labels
bug

Comments

@Apollon77
Copy link
Contributor

Analysis

mainly an info because I found IPv4 as String in the code...

See: nodejs/node#41431 (review)

Expected Behavior

Considers when working on Node.js 18 compatibility

Steps To Reproduce

n/a

Logs

n/a

Configuration

n/a

Environment

Node.js 18

Process Supervisor

not applicable

Additional Context

No response
@Apollon77 Apollon77 added the bug label Apr 23, 2022
mieszkomularczyk added a commit to mieszkomularczyk/HAP-NodeJS that referenced this issue Apr 25, 2022
@mieszkomularczyk
fixes homebridge#945
c39b42f
oznu added a commit that referenced this issue Apr 26, 2022
@oznu
Fix #945 - Node.js v18 os.networkInterfaces()[].family number/string …
b5ff332 
…comparison
oznu added a commit that referenced this issue Apr 27, 2022
@oznu @Supereg
Fix #945 - Node.js v18 os.networkInterfaces()[].family number/string …
11287fc 
…comparison (#947)

Co-authored-by: Andi <[email protected]>
@oznu
Copy link
Member

oznu commented Apr 28, 2022

Fixed as of v0.10.2-beta.3

A release will come shortly.

@oznu oznu closed this as completed Apr 28, 2022
koush pushed a commit to koush/HAP-NodeJS that referenced this issue Jun 28, 2022
@oznu @Supereg
Fix homebridge#945 - Node.js v18 os.networkInterfaces()[].family numb…
fc381e0 
…er/string comparison (homebridge#947)

Co-authored-by: Andi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oznu @Apollon77