Remove Underscore to Space Replacement in MQTT Code #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sunoo
changed the title
|
Looks like #605 is basically doing what this is doing at this point, so closing now. |
|
I'm working on a new pull request right now to add resetting the motion sensor from MQTT right now, should be opening it soon. |
|
@donavanbecker As mentioned earlier, I've opened pull request #606 |
|
Merged, Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix to the underscore to space replacement in the MQTT messages.
In Javascript, string.replace only works on the first instance of the pattern found unless regular expressions are used.