Issue #247 Ensure systemd-journal-gatewayd socket is correct#277
Merged
Conversation
As stated in home-assistant#247 the default action for systemd-journal-gatewayd is to listen on HTTP port while Supervisor needs Unix socket file that's bind mounted in Docker container. This override changes socket location.
As stated in home-assistant#247 with the default setup the path /run/systemd-journal-gatewayd.sock may be a directory, not a file, we have to fix that
Socket location change has been moved to systemd override which is the suggested way of changing original packaged unit behavior
|
Hi @p0wertiger It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
home-assistant
Bot
added
cla-recheck
cla-signed
and removed
cla-recheck
cla-needed
labels
Member
|
@p0wertiger did you see the comment above? |
Contributor
Author
|
Yes, hence the tag cla-signed |
Member
I also asked in the review comment above if the line 2 |
Contributor
Author
|
No, I don't see any review comments other than bot asking to sign CLA. Empty |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to check whether /run/systemd-journal-gatewayd.sock is a socket file. If that's a directory, the socket unit won't start.
Also, socket configuration has been moved to unit override.
Fixes #247