Skip to content

Add supervisor_ingress support#73

Merged
ludeeus merged 3 commits intomainfrom
supervisor_ingress
Jun 1, 2021
Merged

Add supervisor_ingress support#73
ludeeus merged 3 commits intomainfrom
supervisor_ingress

Conversation

@ludeeus
Copy link
Copy Markdown
Member

@ludeeus ludeeus commented May 4, 2021

Comment thread redirect.json Outdated
Comment thread redirect.json Outdated
},
{
"redirect": "supervisor_ingress",
"name": "Supervisor: Ingress",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs add-on in it, to make clear it is for a specific add-on?

Comment thread redirect.json Outdated
{
"redirect": "supervisor_ingress",
"name": "Supervisor: Ingress",
"badge": "Ingress",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe just this one, Add-on: Ingress

Comment thread redirect.json Outdated
Comment on lines +4 to +5
"name": "Add-on: Ingress",
"badge": "Ingress",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You changed the name now, and not the badge, intentional?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you wanted both? 😄

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes 😄

@ludeeus ludeeus merged commit 6c45e08 into main Jun 1, 2021
@ludeeus ludeeus deleted the supervisor_ingress branch June 1, 2021 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants