Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Script" iOS 18 ControlWidget #2952

Merged
merged 5 commits into from
Aug 29, 2024
Merged

Add "Script" iOS 18 ControlWidget #2952

merged 5 commits into from
Aug 29, 2024

Conversation

bgoncal
Copy link
Member

@bgoncal bgoncal commented Aug 29, 2024

Summary

This PR also adds a dependency: SFSafeSymbols to safely iterate over SFSymbols. For ControlWidget we can't use MaterialDesign icons, unless they are converted into custom SFSymbols and embedded in the App but this would increase a lot the App size

Screenshots

Simulator Screenshot - iPhone 15 Pro - 2024-08-29 at 04 17 08

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#

Any other notes

@bgoncal bgoncal requested a review from a team August 29, 2024 02:18
@bgoncal bgoncal self-assigned this Aug 29, 2024
Copy link

emerge-tools bot commented Aug 29, 2024

1 build increased size

Name Version Download Change Install Change Approval
⚠️ Home Assistant
io.robbie.HomeAssistant
2024.9 (2024.3772) 51.6 MB ⬆️ 1.5 MB (3.02%) 116.8 MB ⬆️ 5.0 MB (4.59%) N/A

Home Assistant 2024.9 (2024.3772)
io.robbie.HomeAssistant

⚖️ Compare build
📦 Install build
⏱️ Analyze build performance

Total install size change: ⬆️ 5.0 MB (4.59%)
Total download size change: ⬆️ 1.5 MB (3.02%)

Largest size changes

Item Install Size Change
📝 SFSafeSymbols ⬆️ 2.4 MB
📝 DYLD.Exports ⬆️ 385.8 kB
📝 watch-frame-fade.png ⬆️ 168.4 kB
📝 Strings.Unmapped ⬆️ 132.5 kB
📝 SFSafeSymbols.SFSymbol.localizationsAvailableSince1_0 ⬆️ 117.9 kB
View Treemap

Image of diff


🛸 Powered by Emerge Tools

Comment trigger: Size diff threshold of 100.00kB exceeded

@bgoncal bgoncal merged commit d8c561d into master Aug 29, 2024
5 checks passed
@bgoncal bgoncal deleted the script-controlwidget branch August 29, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant