static var to static let

[michalsrutek]

Summary

• static let plays nicely with modern Swift concurrency (async/await)
• static let makes it impossible to mutate the values - causing undefined behavior in some cases

[michalsrutek]

got these changes just by running the project 🤷

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 28.53%. Comparing base (6c34210) to head (1d6f368).
Report is 52 commits behind head on master.

❗ Current head 1d6f368 differs from pull request most recent head 4b4848c. Consider uploading reports for the commit 4b4848c to get more accurate results

Files	Patch %	Lines
Sources/App/Scenes/WindowSizeObserver.swift	50.00%	1 Missing ⚠️
...urces/Shared/Common/ObjectMapperTransformers.swift	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2642      +/-   ##
==========================================
+ Coverage   27.54%   28.53%   +0.98%     
==========================================
  Files         311      335      +24     
  Lines       31699    23624    -8075     
==========================================
- Hits         8733     6741    -1992     
+ Misses      22966    16883    -6083     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bgoncal]

@zacwest I see some var becoming let inside structs, thats what I also default using even though struct behavior already assures it would be immutable, I know you have an opinion about this, wanna jump in?

[zacwest]

I think for the most part the changes seem good. I don't think the 'static var…' to 'static let…' cases are a problem.

Keep in mind: this project uses the 'World' pattern from Pointfree, so a lot of mutability is actually meant to be in Current rather than elsewhere, and that's the point where things should be overridden. So for example, static let shared xyz = … should actually generally be in Current rather than a singleton on the type. Makes testing easier.

[zacwest]

I think that cases like this - where it's a data type - shouldn't force the non-static members to be let - that's already done by the mutability state of the struct. It's not in and of itself wrong to copy a struct and mutate the value for some reason, as long as the values are valid state changes -- which the type can guard if it wants.

[bgoncal]

Since there is no real impact now, I will merge this PR as-is, we can always change it to var on demand of course when needed to actually do something with the struct.

[bgoncal]

Thank you!