Force closing the app resets the push notifications count.

[mgiako]

If you force the app to close (2.0b55), the new push notification count is reset.
Then I tried to check also the homeassistant.log, the count is also reset there (even with old versions).

[robbiet480]

Unsure exactly what you meant here. Is this about rate limits? @SeanPM5 and I both tested and were unable to reproduce. Can you provide more info @TomBrien & @mgiako?

[mgiako]

sending 3 notifications:

2019-05-09 09:59:58 INFO (MainThread) [homeassistant.components.mobile_app.notify] mobile_app push notification rate limits for iPhone8: 1 sent, 150 allowed, 0 errors, resets in 16:00:01
2019-05-09 10:00:07 INFO (MainThread) [homeassistant.components.mobile_app.notify] mobile_app push notification rate limits for iPhone8: 2 sent, 150 allowed, 0 errors, resets in 15:59:52
2019-05-09 10:00:09 INFO (MainThread) [homeassistant.components.mobile_app.notify] mobile_app push notification rate limits for iPhone8: 3 sent, 150 allowed, 0 errors, resets in 15:59:50

force close the app.
send another one:

2019-05-09 10:03:35 INFO (MainThread) [homeassistant.components.mobile_app.notify] mobile_app push notification rate limits for iPhone8: 1 sent, 150 allowed, 0 errors, resets in 15:56:24

... the count is reset

[mgiako]

ok, so we revealed the mystery. Rate limits are reset at closing because the push id is also reset at each closure.
But why does someone push id change and someone doesn't?

[mgiako]

The reset thing works, the push id changes and from that moment on it doesn't change any more at every restart. But now I think, does it end here? This way, if you finish the notifications, you can simply reset the push id and start again. Perhaps the reset should activate automatically and not be available to the user. Is it possible that the app realizes that the push id changes and automatically reset it?

[TomBrien]

@mgiako I agree that it's open to exploitation maybe some automatic reset of it every few days when the app knows it is connect to HA is in order? Anyway I'm going to close this as the original bug is fixed.

[robbiet480]

I'm not going to implement anything automatic to fix this as Firebase is imminently rolling out a long term fix for this, see firebase/firebase-ios-sdk#2438 (comment).