Fix problem with cameras that don't support time#23924
Merged
Merged
Conversation
Some onvif cameras don't support Date management. In that case None is returned and script crashes when trying to obtain date
homeassistant
added
integration: onvif
merging-to-master
Contributor
|
Make sure you are basing your PR against |
balloob
removed
the
merging-to-master
balloob
approved these changes
May 17, 2019
balloob
pushed a commit
that referenced
this pull request
May 17, 2019
Some onvif cameras don't support Date management. In that case None is returned and script crashes when trying to obtain date
Merged
|
I have a similar issue after upgrade to 0.93 and 0.93.1 too. My old onvif cameras crashes if i configure them on HA. With 0.92 everything worked fine. |
Member
|
Please open an issue if you suspect a bug. If you need help please use our help channels: Merged PRs should not be used for support or bug reports. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Some onvif cameras don't support Date management. In that case None is returned and script crashes when trying to obtain date
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.If the code does not interact with devices: