Skip to content

Fix problem with cameras that don't support time #23924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balloob merged 1 commit into from
May 17, 2019
Merged

Fix problem with cameras that don't support time #23924

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 22 additions & 21 deletions homeassistant/components/onvif/camera.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,27 +164,28 @@ async def async_initialize(self):

system_date = dt_util.utcnow()
device_time = await devicemgmt.GetSystemDateAndTime()
cdate = device_time.UTCDateTime
cam_date = dt.datetime(cdate.Date.Year, cdate.Date.Month,
cdate.Date.Day, cdate.Time.Hour,
cdate.Time.Minute, cdate.Time.Second,
0, dt_util.UTC)

_LOGGER.debug("Camera date/time: %s",
cam_date)

_LOGGER.debug("System date/time: %s",
system_date)

dt_diff = cam_date - system_date
dt_diff_seconds = dt_diff.total_seconds()

if dt_diff_seconds > 5:
_LOGGER.warning("The date/time on the camera is '%s', "
"which is different from the system '%s', "
"this could lead to authentication issues",
cam_date,
system_date)
if device_time:
cdate = device_time.UTCDateTime
cam_date = dt.datetime(cdate.Date.Year, cdate.Date.Month,
cdate.Date.Day, cdate.Time.Hour,
cdate.Time.Minute, cdate.Time.Second,
0, dt_util.UTC)

_LOGGER.debug("Camera date/time: %s",
cam_date)

_LOGGER.debug("System date/time: %s",
system_date)

dt_diff = cam_date - system_date
dt_diff_seconds = dt_diff.total_seconds()

if dt_diff_seconds > 5:
_LOGGER.warning("The date/time on the camera is '%s', "
"which is different from the system '%s', "
"this could lead to authentication issues",
cam_date,
system_date)

_LOGGER.debug("Obtaining input uri")

Expand Down