Skip to content

Add Wake over Lan support for Panasonic Viera#21365

Merged
fabaff merged 1 commit into
home-assistant:devfrom
Tony763:Tony763-patch-1
Feb 23, 2019
Merged

Add Wake over Lan support for Panasonic Viera#21365
fabaff merged 1 commit into
home-assistant:devfrom
Tony763:Tony763-patch-1

Conversation

@Tony763
Copy link
Copy Markdown
Contributor

@Tony763 Tony763 commented Feb 23, 2019

Description:

Pass a ip address of device to WOL. Without it will not work on my TV.

Tox didn't pass. Tried pylint homeassistant/components/media_player/panasonic_v iera.py and it say:
panasonic_viera.py:45:4: E0611: No name 'RemoteControl' in module 'pana sonic_viera' (no-name-in-module) and this part I didn't touch.

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

media_player:
  - platform: panasonic_viera
    host: "10.0.1.108"
    mac: "20:C6:EB:AB:8B:20"

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

Copy link
Copy Markdown
Contributor

@dgomes dgomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@fabaff fabaff merged commit 6743ef1 into home-assistant:dev Feb 23, 2019
@ghost ghost removed the in progress label Feb 23, 2019
@balloob balloob mentioned this pull request Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants