Skip to content

Add Wake over Lan support for Panasonic Viera#21338

Closed
Tony763 wants to merge 1 commit into
home-assistant:masterfrom
Tony763:patch-1
Closed

Add Wake over Lan support for Panasonic Viera#21338
Tony763 wants to merge 1 commit into
home-assistant:masterfrom
Tony763:patch-1

Conversation

@Tony763
Copy link
Copy Markdown
Contributor

@Tony763 Tony763 commented Feb 22, 2019

Description:

Pass a ip address of device to WOL. Without it will not work on my TV.

Tox didn't pass. Tried pylint homeassistant/components/media_player/panasonic_v iera.py and it say:
panasonic_viera.py:45:4: E0611: No name 'RemoteControl' in module 'pana sonic_viera' (no-name-in-module) and this part I didn't touch.

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

media_player:
  - platform: panasonic_viera
    host: "10.0.1.108"
    mac: "20:C6:EB:AB:8B:20"

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

Pass a ip address of device to WOL. Without it will not work on my TV.
```
media_player:
  - platform: panasonic_viera
    host: "10.0.1.108"
    mac: "20:C6:EB:AB:8B:20"
```
@homeassistant
Copy link
Copy Markdown
Contributor

Hi @Tony763,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@homeassistant homeassistant added cla-needed merging-to-master This PR is merging into the master branch and should probably change the branch to `dev`. platform: media_player.panasonic_viera small-pr PRs with less than 30 lines. labels Feb 22, 2019
@ghost ghost added the in progress label Feb 22, 2019
@fabaff fabaff changed the title Panasonic_viera.py - Wake over Lan Add Wake over Lan support for Panasonic Viera Feb 23, 2019
@fabaff fabaff changed the base branch from master to dev February 23, 2019 13:44
@fabaff fabaff changed the base branch from dev to master February 23, 2019 13:45
@fabaff
Copy link
Copy Markdown
Member

fabaff commented Feb 23, 2019

Yes, please rebase. Branch can't be changed on GitHub.

@Tony763
Copy link
Copy Markdown
Contributor Author

Tony763 commented Feb 23, 2019

Sorry for that. Didn't find a way to rebase in web interface. Created as new PR #21365.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed integration: panasonic_viera merging-to-master This PR is merging into the master branch and should probably change the branch to `dev`. small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants