Conversation
homeassistant
added
integration: geofency
small-pr
ghost
assigned
Member
rohankapoorcom
left a comment
rohankapoorcom
left a comment
There was a problem hiding this comment.
Seems easier to do:
if DOMAIN not in hass_config:
hass.data[DOMAIN] = []
return True
If we did that at the beginning, we'd have to make no other changes.
Member
Author
|
Either is fine I think, it's all so small. |
|
This did not fix geofency. I upgraded HA to 0.87.0 with a
|
2 tasks
rohankapoorcom
pushed a commit
to home-assistant/home-assistant.io
that referenced
this pull request
Feb 15, 2019
* Remove config.yaml part As part of PR home-assistant/core#20631 an entry in configuration.yaml is no longer necessary. * Put mobile beacons back in
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
With a config entry, there can be no entry in configuration.yaml. This adds code for this case.
Reported via chat.
Fixes home-assistant/home-assistant.io#8362
CC @rohankapoorcom