Skip to content

Remove config.yaml entry for Geofency#8442

Merged
rohankapoorcom merged 2 commits intohome-assistant:currentfrom
gerard33:patch-4
Feb 15, 2019
Merged

Remove config.yaml entry for Geofency#8442
rohankapoorcom merged 2 commits intohome-assistant:currentfrom
gerard33:patch-4

Conversation

@gerard33
Copy link
Copy Markdown
Contributor

@gerard33 gerard33 commented Feb 7, 2019

Description:
As part of PR home-assistant/core#20631 an entry in configuration.yaml is no longer necessary.

Pull request in home-assistant (if applicable): home-assistant/core#20631

cc: @rohankapoorcom

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

As part of PR home-assistant/core#20631 an entry in configuration.yaml is no longer necessary.
@ghost ghost added the to-do label Feb 7, 2019
@gerard33 gerard33 changed the title Remove config.yaml part Remove config.yaml entry for Geofency Feb 7, 2019
@frenck
Copy link
Copy Markdown
Member

frenck commented Feb 13, 2019

Because it is no longer necessary, doesn't mean it is no longer working?
One could still use this.

@gerard33
Copy link
Copy Markdown
Contributor Author

@frenck, I have made this PR based on this description by balloob in PR home-assistant/core#20631

With a config entry, there can be no entry in configuration.yaml.

I will change the PR so the mobile_beacons part stays in.

@rohankapoorcom rohankapoorcom merged commit bd9b0b7 into home-assistant:current Feb 15, 2019
@ghost ghost removed the to-do label Feb 15, 2019
@rohankapoorcom
Copy link
Copy Markdown
Member

Thanks! :)

@klaasnicolaas klaasnicolaas added enhancement current This PR goes into the current branch labels Feb 15, 2019
@gerard33 gerard33 deleted the patch-4 branch February 15, 2019 07:59
@frenck
Copy link
Copy Markdown
Member

frenck commented Feb 15, 2019

👍 @gerard33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

current This PR goes into the current branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants