Add new launch sensor to keep track of space launches.#18274
Add new launch sensor to keep track of space launches.#18274fabaff merged 7 commits intohome-assistant:devfrom ludeeus:launch
Conversation
fabaff
left a comment
There was a problem hiding this comment.
I think that we should throttle the sensor by default. Maybe something like 10 or 15 min. The data is pretty static and there seems to be no need to poll with the default interval.
|
I will add that @fabaff and also make the package reuse the aiohttp session from homeassistant as mentioned here: #18237 (comment) |
|
10 or 15 minutes? What about 24 hours? This is very static info… |
|
Some days have multiple launches, my plan was to set it to 1-hour intervals |
|
I guess the |
MartinHjelmare
left a comment
There was a problem hiding this comment.
Just some style things.
…ry_code, remove CONF_ from ATTRIBUTION.
amelchio
left a comment
There was a problem hiding this comment.
I think this is ready to fly!
|
Soo, would people agree that this name is a bit too generic ? |
|
I would think that launch_library would be a better name, as it reflects the name of the service. |
|
@balloob I do not disagree with that do you want me to make a PR to change it? |
|
Yes let's do it to before it is released |
|
I'll start that now :) |
|
I would like to build a countdown sensor and it would be very useful if this launch sensor had an attribute based on the "wsstamp" field. IE the unix formatted window start time. |
|
@HemiBob Please don't use closed/merged pull requests for seeking help/support/feature requests. For the right place see: https://www.home-assistant.io/help |
Description:
Adda a new sensor to show the next upcoming space launch 🚀
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7397
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.