Skip to content

Fan should be interpreted as Fan in Google Assistant#17792

Merged
balloob merged 1 commit intohome-assistant:devfrom
mariuszluciow:google-assistant/fan
Oct 28, 2018
Merged

Fan should be interpreted as Fan in Google Assistant#17792
balloob merged 1 commit intohome-assistant:devfrom
mariuszluciow:google-assistant/fan

Conversation

@mariuszluciow
Copy link
Copy Markdown
Contributor

@mariuszluciow mariuszluciow commented Oct 25, 2018

Description:

Google has a separate type for Fan devices.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost ghost added the in progress label Oct 25, 2018
@mariuszluciow mariuszluciow changed the title Google assistant/fan WIP Google assistant/fan Oct 25, 2018
@mariuszluciow mariuszluciow changed the title WIP Google assistant/fan WIP Fan should be interpreted as Fan in Google Assistant Oct 25, 2018
@michaelarnauts
Copy link
Copy Markdown
Contributor

This PR is about vacuum. You want to split that into a different PR.

@mariuszluciow
Copy link
Copy Markdown
Contributor Author

@michaelarnauts waiting for #17657 to be merged first, to avoid conflicts.

@balloob
Copy link
Copy Markdown
Member

balloob commented Oct 26, 2018

okay, other one is merged, please rebase.

Copy link
Copy Markdown

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

Copy link
Copy Markdown

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

@mariuszluciow mariuszluciow changed the title WIP Fan should be interpreted as Fan in Google Assistant Fan should be interpreted as Fan in Google Assistant Oct 27, 2018
@mariuszluciow
Copy link
Copy Markdown
Contributor Author

@balloob rebased

@balloob balloob merged commit 38576e5 into home-assistant:dev Oct 28, 2018
@ghost ghost removed the in progress label Oct 28, 2018
@balloob
Copy link
Copy Markdown
Member

balloob commented Oct 28, 2018

Thanks!

@balloob balloob mentioned this pull request Nov 9, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants