Fan should be interpreted as Fan in Google Assistant#17792
Merged
balloob merged 1 commit intohome-assistant:devfrom Oct 28, 2018
Merged
Fan should be interpreted as Fan in Google Assistant#17792balloob merged 1 commit intohome-assistant:devfrom
balloob merged 1 commit intohome-assistant:devfrom
Conversation
d0a53ec to
65ae04e
Compare
65ae04e to
abdf5e9
Compare
Contributor
|
This PR is about vacuum. You want to split that into a different PR. |
Contributor
Author
|
@michaelarnauts waiting for #17657 to be merged first, to avoid conflicts. |
Member
|
okay, other one is merged, please rebase. |
abdf5e9 to
14f37f6
Compare
houndci-bot
reviewed
Oct 27, 2018
houndci-bot
left a comment
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Traceback (most recent call last):
Traceback (most recent call last):
File "/home/linters/.local/bin/flake8", line 7, in
from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'
14f37f6 to
5c0f645
Compare
houndci-bot
reviewed
Oct 27, 2018
houndci-bot
left a comment
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Traceback (most recent call last):
Traceback (most recent call last):
File "/home/linters/.local/bin/flake8", line 7, in
from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'
Contributor
Author
|
@balloob rebased |
balloob
approved these changes
Oct 28, 2018
Member
|
Thanks! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Google has a separate type for Fan devices.
Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: