Add data/data_template/title to alert component#17616
Merged
MartinHjelmare merged 15 commits intohome-assistant:devfrom Jan 23, 2019
Merged
Add data/data_template/title to alert component#17616MartinHjelmare merged 15 commits intohome-assistant:devfrom
MartinHjelmare merged 15 commits intohome-assistant:devfrom
Conversation
Contributor
houndci-bot
reviewed
Oct 19, 2018
Contributor
Author
|
The |
2 tasks
Member
|
https://travis-ci.org/home-assistant/home-assistant/jobs/443714441#L1098 - you added extra arguments to the init function, the tests will need to be updated to include those. |
3 tasks
Member
|
Is this PR clashing with #17516? |
Member
|
It did. Pr should be rebased |
Contributor
|
I would decouple the extended template handling from the changes to the alert component, as this would be helpful for other templates as well. |
…eature/alert_data_parameter
houndci-bot
reviewed
Nov 1, 2018
houndci-bot
reviewed
Nov 6, 2018
marchingphoenix
approved these changes
Dec 14, 2018
houndci-bot
reviewed
Jan 22, 2019
MartinHjelmare
approved these changes
Jan 23, 2019
Merged
alandtse
pushed a commit
to alandtse/home-assistant
that referenced
this pull request
Feb 12, 2019
* Add data/data_template/title to alert component * Fix line length * Fix tests * Fix lint * fix line length * Fix tests, make title templatable * Fix test * Fix test * Optimize data, make title templated * Fix line length * Add title template * typo * Fix tests
kellerza
pushed a commit
to kellerza/ha-core
that referenced
this pull request
Feb 24, 2019
* Add data/data_template/title to alert component * Fix line length * Fix tests * Fix lint * fix line length * Fix tests, make title templatable * Fix test * Fix test * Optimize data, make title templated * Fix line length * Add title template * typo * Fix tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#6968
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed: