Skip to content

Add data/data_template/title to alert component#17616

Merged
MartinHjelmare merged 15 commits intohome-assistant:devfrom
syphernl:feature/alert_data_parameter
Jan 23, 2019
Merged

Add data/data_template/title to alert component#17616
MartinHjelmare merged 15 commits intohome-assistant:devfrom
syphernl:feature/alert_data_parameter

Conversation

@syphernl
Copy link
Copy Markdown
Contributor

@syphernl syphernl commented Oct 19, 2018

Description:

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#6968

Example entry for configuration.yaml (if applicable):

# Example configuration.yaml entry
alert:
  garage_door:
    name: Garage is open
    entity_id: input_boolean.garage_door
    state: 'on'   # Optional, 'on' is the default value
    repeat:
      - 15
      - 30
      - 60
    can_acknowledge: True  # Optional, default is True
    skip_first: True  # Optional, false is the default
    title: 'Garage'
    data:
      data:
        inline_keyboard:
          - 'Close garage:/close_garage, Acknowledge:/garage_acknowledge'
    notifiers:
      - frank_telegram

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

@homeassistant
Copy link
Copy Markdown
Contributor

Hi @syphernl,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@syphernl
Copy link
Copy Markdown
Contributor Author

The tox tests are failing, not sure why though. Any pointers?

@cgarwood
Copy link
Copy Markdown
Member

https://travis-ci.org/home-assistant/home-assistant/jobs/443714441#L1098 - you added extra arguments to the init function, the tests will need to be updated to include those.

@MartinHjelmare
Copy link
Copy Markdown
Member

Is this PR clashing with #17516?

@balloob
Copy link
Copy Markdown
Member

balloob commented Nov 1, 2018

It did. Pr should be rebased

@thoscut
Copy link
Copy Markdown
Contributor

thoscut commented Nov 1, 2018

I would decouple the extended template handling from the changes to the alert component, as this would be helpful for other templates as well.

@MartinHjelmare MartinHjelmare merged commit db277ad into home-assistant:dev Jan 23, 2019
@ghost ghost removed the in progress label Jan 23, 2019
@balloob balloob mentioned this pull request Feb 6, 2019
alandtse pushed a commit to alandtse/home-assistant that referenced this pull request Feb 12, 2019
* Add data/data_template/title to alert component

* Fix line length

* Fix tests

* Fix lint

* fix line length

* Fix tests, make title templatable

* Fix test

* Fix test

* Optimize data, make title templated

* Fix line length

* Add title template

* typo

* Fix tests
kellerza pushed a commit to kellerza/ha-core that referenced this pull request Feb 24, 2019
* Add data/data_template/title to alert component

* Fix line length

* Fix tests

* Fix lint

* fix line length

* Fix tests, make title templatable

* Fix test

* Fix test

* Optimize data, make title templated

* Fix line length

* Add title template

* typo

* Fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants