Skip to content

Add docs for data parameter in alert component#6968

Merged
MartinHjelmare merged 8 commits intohome-assistant:nextfrom
syphernl:feature/alert_data_parameter
Jan 23, 2019
Merged

Add docs for data parameter in alert component#6968
MartinHjelmare merged 8 commits intohome-assistant:nextfrom
syphernl:feature/alert_data_parameter

Conversation

@syphernl
Copy link
Copy Markdown
Contributor

Description:

Pull request in home-assistant (if applicable): home-assistant/core#17616

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@ghost ghost added the to-do label Oct 19, 2018
@frenck frenck added Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! new-feature This PR adds documentation for a new Home Assistant feature to an existing integration ready-for-review This PR needs to be reviewed next This PR goes into the next branch has-parent This PR has a parent PR in another repo and removed to-do labels Oct 21, 2018
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @syphernl! I've reviewed it and left you some comments.
Could you please take a look? 👍

@frenck frenck added in-progress This PR/Issue is currently being worked on and removed ready-for-review This PR needs to be reviewed labels Oct 21, 2018
@syphernl
Copy link
Copy Markdown
Contributor Author

@frenck Thanks for your feedback.I have made the requested changes.

@frenck frenck added awaits-parent Awaits the merge of an parent PR and removed in-progress This PR/Issue is currently being worked on labels Oct 23, 2018
frenck
frenck previously approved these changes Oct 23, 2018
@frenck
Copy link
Copy Markdown
Member

frenck commented Oct 23, 2018

Thanks for updating the PR @syphernl! 👍

✅ Approved. Can be merged as soon as the parent PR gets merged.

@stale
Copy link
Copy Markdown

stale bot commented Jan 5, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale The PR had no activity for quite some time, and is marked as Stale label Jan 5, 2019
@syphernl
Copy link
Copy Markdown
Contributor Author

syphernl commented Jan 6, 2019

This isn't stale.

@stale stale bot removed the stale The PR had no activity for quite some time, and is marked as Stale label Jan 6, 2019
@frenck frenck added the parent-merged The parent PR has been merged already label Jan 23, 2019
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit edfc745 into home-assistant:next Jan 23, 2019
@ghost ghost removed the awaits-parent Awaits the merge of an parent PR label Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch parent-merged The parent PR has been merged already

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants