Merged
Conversation
ghost
assigned
2 tasks
Member
MartinHjelmare
left a comment
MartinHjelmare
left a comment
There was a problem hiding this comment.
Nice! Some small comments.
| SUPPORT_FAN_MODE | SUPPORT_ON_OFF) | ||
|
|
||
| PLATFORM_SCHEMA = PLATFORM_SCHEMA.extend({ | ||
| vol.Required(CONF_EMAIL): cv.string, |
Member
There was a problem hiding this comment.
We most often use CONF_USERNAME even for email username. But you decide what fits best.
| async_add_entities(dev) | ||
|
|
||
|
|
||
| class MilHeater(ClimateDevice): |
Member
There was a problem hiding this comment.
Maybe call it MillHeater?
| return self._heater.device_status == 0 # weird api choice | ||
|
|
||
| @property | ||
| def state(self): |
Member
There was a problem hiding this comment.
Overwrite is_on to communicate on/off state.
| @property | ||
| def is_on(self): | ||
| """Return true if heater is on.""" | ||
| return True if self._heater.power_status == 1 else False |
Member
There was a problem hiding this comment.
return self._heater.power_status == 1
MartinHjelmare
approved these changes
Oct 14, 2018
Member
MartinHjelmare
left a comment
MartinHjelmare
left a comment
There was a problem hiding this comment.
Great! Can be merged when build passes.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
New climate device
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#6659
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable ([example][ex-requir]).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.