Skip to content

Create climate.mill.markdown#6659

Merged
MartinHjelmare merged 12 commits into
nextfrom
Danielhiversen-patch-1
Oct 15, 2018
Merged

Create climate.mill.markdown#6659
MartinHjelmare merged 12 commits into
nextfrom
Danielhiversen-patch-1

Conversation

@Danielhiversen
Copy link
Copy Markdown
Member

Description:

Pull request in home-assistant (if applicable): home-assistant/core#17313

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follow the standards.

@ghost ghost assigned Danielhiversen Oct 10, 2018
@ghost ghost added the ready-for-review This PR needs to be reviewed label Oct 10, 2018
@frenck frenck added Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! new-integration This PR adds documentation for a new Home Assistant integration next This PR goes into the next branch has-parent This PR has a parent PR in another repo labels Oct 11, 2018
@ghost ghost assigned frenck Oct 11, 2018
frenck
frenck previously approved these changes Oct 11, 2018
@frenck frenck added awaits-parent Awaits the merge of an parent PR and removed ready-for-review This PR needs to be reviewed labels Oct 11, 2018
@frenck
Copy link
Copy Markdown
Member

frenck commented Oct 11, 2018

Thanks, @Danielhiversen 👍

✅ Approved. Can be merged as soon as the parent PR gets merged.
⚠️ The ha_release might need an update before merging this one in.

@Danielhiversen Danielhiversen added the parent-merged The parent PR has been merged already label Oct 14, 2018

Integrates Mill heater into Home Assistant.

The component requires the heater is sat as an independent device in the Mill app:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... requires that the heater is set as an independent device...


{% configuration %}
username:
description: Your registred Mill email.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

registered

Comment thread source/_components/climate.mill.markdown
Integrates Mill heater into Home Assistant.

The component requires the heater is sat as an independent device in the Mill app:
The component requires that the heater is sat as an independent device in the Mill app:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sat -> set

MartinHjelmare
MartinHjelmare previously approved these changes Oct 14, 2018
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just looked at the preview and found some more things.


```yaml
climate:
- platform: mill
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a space before the dash, to make the indentation 2 space?

Integrates Mill heater into Home Assistant.

The component requires that the heater is set as an independent device in the Mill app:
https://millheat.zendesk.com/hc/en-us/articles/115001123491-What-is-an-Independent-device-
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This url isn't a link. Do we want it to be a link?

@Danielhiversen
Copy link
Copy Markdown
Member Author

Where do you see the preview?

@MartinHjelmare
Copy link
Copy Markdown
Member

When the build is done at netlify they serve us a preview of the PR of the whole site. Just click the build link. It's awesome!

MartinHjelmare
MartinHjelmare previously approved these changes Oct 14, 2018
@MartinHjelmare MartinHjelmare merged commit fb98bd5 into next Oct 15, 2018
@ghost ghost removed the awaits-parent Awaits the merge of an parent PR label Oct 15, 2018
@frenck frenck deleted the Danielhiversen-patch-1 branch October 16, 2018 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! has-parent This PR has a parent PR in another repo new-integration This PR adds documentation for a new Home Assistant integration next This PR goes into the next branch parent-merged The parent PR has been merged already

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants