Create climate.mill.markdown#6659
Merged
Merged
Conversation
7 tasks
frenck
previously approved these changes
Oct 11, 2018
Member
|
Thanks, @Danielhiversen 👍 ✅ Approved. Can be merged as soon as the parent PR gets merged. |
|
|
||
| Integrates Mill heater into Home Assistant. | ||
|
|
||
| The component requires the heater is sat as an independent device in the Mill app: |
Member
There was a problem hiding this comment.
... requires that the heater is set as an independent device...
|
|
||
| {% configuration %} | ||
| username: | ||
| description: Your registred Mill email. |
| Integrates Mill heater into Home Assistant. | ||
|
|
||
| The component requires the heater is sat as an independent device in the Mill app: | ||
| The component requires that the heater is sat as an independent device in the Mill app: |
Member
MartinHjelmare
left a comment
There was a problem hiding this comment.
Just looked at the preview and found some more things.
|
|
||
| ```yaml | ||
| climate: | ||
| - platform: mill |
Member
There was a problem hiding this comment.
Maybe add a space before the dash, to make the indentation 2 space?
| Integrates Mill heater into Home Assistant. | ||
|
|
||
| The component requires that the heater is set as an independent device in the Mill app: | ||
| https://millheat.zendesk.com/hc/en-us/articles/115001123491-What-is-an-Independent-device- |
Member
There was a problem hiding this comment.
This url isn't a link. Do we want it to be a link?
Member
Author
|
Where do you see the preview? |
Member
|
When the build is done at netlify they serve us a preview of the PR of the whole site. Just click the build link. It's awesome! |
MartinHjelmare
previously approved these changes
Oct 14, 2018
MartinHjelmare
approved these changes
Oct 15, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Pull request in home-assistant (if applicable): home-assistant/core#17313
Checklist:
nextis for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created againstcurrent.