Fix linky sensor login error by Debaru · Pull Request #17110 · home-assistant/core

Debaru · 2018-10-03T19:10:26Z

Description:

Fix linky sensor login error .

Related issue (if applicable): fixes #17077

Checklist:

The code change is tested and works locally.
Local tests pass with tox. Your PR cannot be merged unless tests pass

homeassistant · 2018-10-03T19:10:27Z

Hi @Debaru,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

hobbe · 2018-10-03T21:16:01Z

homeassistant/components/sensor/linky.py

-        from pylinky.client import PyLinkyError
+        from pylinky.client import LinkyClient, PyLinkyError
+
+        client = LinkyClient(self._username, self._password)


You probably need to close the session after fetch_data().
See also pyLinky main.

finally: client.close_session()

homeassistant/components/sensor/linky.py

Adding following enhancements: * Make sure the platform loads correctly by making the first API request in setup_platform. * Close the session after each API call. * Use timeout parameter everywhere.

Make platform fail-safe

houndci-bot · 2018-10-04T10:58:53Z

homeassistant/components/sensor/linky.py

-        from pylinky.client import PyLinkyError
+        from pylinky.client import LinkyClient, PyLinkyError
+
+        client = LinkyClient(self._username, self._password, None, self._timeout)


line too long (81 > 79 characters)

Fix Hound CI error: line too long.

MartinHjelmare · 2018-10-05T08:44:37Z

Please add to the PR description, why this change solves the issue.

Debaru · 2018-10-05T09:52:20Z

Sorry.

commit 164d82e fix @fabaff request. @hobbe add timeout parameter and check sensor works in setup_platform.
commit 36676e0 fix Fix Hound CI error: line too long.

Is it okay ? First PR here =)

MartinHjelmare · 2018-10-05T10:31:45Z

homeassistant/components/sensor/linky.py

-        from pylinky.client import PyLinkyError
+        from pylinky.client import LinkyClient, PyLinkyError
+
+        client = LinkyClient(self._username, self._password, None,


Why do we need to create a new client on every update?

First solution use one client, created in setup_platform, but it's seems to not work (Login error).
With a new client on every update, that resolve the issue.

It would be good to know why.

I agree with you.
My solution was a hotfix what work for me and closing error login issue, it's why i share it. In wait I've found a better solution, do you want I cancel my PR ?

We shouldn't necessarily close this. Let's hear what other reviewers think. If this PR fixes the problem, that's a first step.

I can confirm that this fixes the original issue.

I have tried to re-use the client, but the original error occurs again.
It seems that the session cannot be re-used. Then this might be an issue in the pyLinky library.

After some tests, I agree with @hobbe : pyLinky library session cannot be re-used.
So, for now, we need to re-create an client at each update.

I suggest that you open an issue for pyLinky to get it fixed.

I've open a PR on pyLinly library to improve client (Pirionfr/pyLinky#5).

mbo18 · 2018-10-09T12:20:34Z

Can this fix be pushed to 0.80 as this component is not working since its release in 0.79?
Thank you

hobbe · 2018-10-09T19:32:04Z

@mbo18, see this temporary workaround.

houndci-bot · 2018-10-20T12:31:06Z

homeassistant/components/sensor/linky.py

    def update(self):
        """Fetch new state data for the sensor."""
-        from pylinky.client import PyLinkyError
+        from pylinky.client import LinkyClient, PyLinkyError


'pylinky.client.LinkyClient' imported but unused

Debaru · 2018-10-20T12:46:51Z

Now, we are using last pyLink version (0.1.8) which allow to reuse client session.
Available if you have some questions.

MartinHjelmare

Great!

CygaLV · 2019-01-27T22:08:27Z

Hi !
It seems that the problem reappeared !
It worked fine for me until recently (1 or 2 weeks I guess).
And now it fails saying my password and user are wrong.
PyLinky version I have is 0.1.8. It is the latest right ?
I'm using it on a Synology NAS DS216j.

I modified the python source file to expose the user and names, and I can guarantee they are valid.

Trying to trace the execution, it seems that it fails finding the cookie iPlanetDirectoryPro. I checked with the debug options of my web browser, and locally I've got this cookie...
I've also checked the SunQueryParamsString, and it seems that it is good.

One thing though, now, when connecting on the Enedis webpage, it doesn't bring you to your user space, but it rather do several redirections (during these redirections the cookie seems to be not accessible) and brings to you to the website welcome page (iPlanetDirectoryPro) is then available.

Am I the only one with this issue ?

MartinHjelmare · 2019-01-27T22:44:47Z

Please open an issue if you suspect a bug. If you need help please use our help channels:
https://home-assistant.io/help/#communication-channels

Merged PRs should not be used for support or bug reports. Thanks!

Fix linky sensor login error

3fd0894

homeassistant added cla-needed platform: sensor.linky small-pr PRs with less than 30 lines. labels Oct 3, 2018

ghost added the in progress label Oct 3, 2018

homeassistant added cla-signed and removed cla-needed labels Oct 3, 2018

hobbe reviewed Oct 3, 2018

View reviewed changes

fabaff requested changes Oct 3, 2018

View reviewed changes

homeassistant/components/sensor/linky.py Outdated Show resolved Hide resolved

bachya added the Hacktoberfest label Oct 3, 2018

hobbe and others added 2 commits October 4, 2018 09:56

Make platform fail-safe

164d82e

Adding following enhancements: * Make sure the platform loads correctly by making the first API request in setup_platform. * Close the session after each API call. * Use timeout parameter everywhere.

Merge pull request #1 from hobbe/patch-1

00aabb5

Make platform fail-safe

houndci-bot reviewed Oct 4, 2018

View reviewed changes

hobbe and others added 2 commits October 4, 2018 14:00

Fix Hound CI error: line too long.

ce363ee

Merge pull request #2 from hobbe/patch-1

36676e0

Fix Hound CI error: line too long.

MartinHjelmare reviewed Oct 5, 2018

View reviewed changes

Julien Debaru added 2 commits October 20, 2018 09:54

Merge remote-tracking branch 'upstream/dev' into dev

0d2ca56

Update pylinky library

276c46b

houndci-bot reviewed Oct 20, 2018

View reviewed changes

Remove LinkyClient from update()

7eddc42

MartinHjelmare approved these changes Oct 20, 2018

View reviewed changes

MartinHjelmare merged commit e980d1b into home-assistant:dev Oct 20, 2018

ghost removed the in progress label Oct 20, 2018

balloob mentioned this pull request Oct 26, 2018

0.81 #17809

Merged

home-assistant locked as resolved and limited conversation to collaborators Jan 27, 2019

ghost added integration: linky and removed platform: sensor.linky labels Mar 21, 2019

Uh oh!

Conversation

Debaru commented Oct 3, 2018

Description:

Checklist:

Uh oh!

homeassistant commented Oct 3, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MartinHjelmare commented Oct 5, 2018

Uh oh!

Debaru commented Oct 5, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Debaru Oct 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MartinHjelmare Oct 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mbo18 commented Oct 9, 2018

Uh oh!

hobbe commented Oct 9, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Debaru commented Oct 20, 2018

Uh oh!

MartinHjelmare left a comment

Choose a reason for hiding this comment

Uh oh!

CygaLV commented Jan 27, 2019

Uh oh!

MartinHjelmare commented Jan 27, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Debaru Oct 5, 2018 •

edited

Loading

MartinHjelmare Oct 5, 2018 •

edited

Loading