Skip to content

Fix linky sensor login error #17110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MartinHjelmare merged 8 commits into from
Oct 20, 2018
Merged

Fix linky sensor login error #17110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3fd0894
Fix linky sensor login error
Oct 3, 2018
164d82e
Make platform fail-safe
hobbe Oct 4, 2018
00aabb5
Merge pull request #1 from hobbe/patch-1
Debaru Oct 4, 2018
ce363ee
Fix Hound CI error: line too long.
hobbe Oct 4, 2018
36676e0
Merge pull request #2 from hobbe/patch-1
Debaru Oct 4, 2018
0d2ca56
Merge remote-tracking branch 'upstream/dev' into dev
Oct 20, 2018
276c46b
Update pylinky library
Oct 20, 2018
7eddc42
Remove LinkyClient from update()
Oct 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions homeassistant/components/sensor/linky.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
from homeassistant.util import Throttle
import homeassistant.helpers.config_validation as cv

REQUIREMENTS = ['pylinky==0.1.6']
REQUIREMENTS = ['pylinky==0.1.8']
_LOGGER = logging.getLogger(__name__)

SCAN_INTERVAL = timedelta(minutes=10)
Expand All @@ -37,11 +37,11 @@ def setup_platform(hass, config, add_entities, discovery_info=None):

from pylinky.client import LinkyClient, PyLinkyError
client = LinkyClient(username, password, None, timeout)

try:
client.fetch_data()
except PyLinkyError as exp:
_LOGGER.error(exp)
client.close_session()
return

devices = [LinkySensor('Linky', client)]
Expand Down Expand Up @@ -80,6 +80,7 @@ def update(self):
self._client.fetch_data()
except PyLinkyError as exp:
_LOGGER.error(exp)
self._client.close_session()
return

_LOGGER.debug(json.dumps(self._client.get_data(), indent=2))
Expand Down
2 changes: 1 addition & 1 deletion requirements_all.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -963,7 +963,7 @@ pylgnetcast-homeassistant==0.2.0.dev0
pylgtv==0.1.9

# homeassistant.components.sensor.linky
pylinky==0.1.6
pylinky==0.1.8

# homeassistant.components.litejet
pylitejet==0.1
Expand Down