BMW Connected drive: option to disable the services#15993
Merged
balloob merged 12 commits intohome-assistant:devfrom Aug 16, 2018
Alexxander0:dev
Merged
BMW Connected drive: option to disable the services#15993balloob merged 12 commits intohome-assistant:devfrom Alexxander0:dev
balloob merged 12 commits intohome-assistant:devfrom
Alexxander0:dev
Conversation
Contributor
|
Hi @Alexxander0, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
homeassistant
added
integration: bmw_connected_drive
platform: lock.bmw_connected_drive
small-pr
ghost
added
the
houndci-bot
reviewed
Aug 15, 2018
| enable_services = account_config[CONF_ENABLE_SERVICES] | ||
| _LOGGER.debug('Adding new account %s', name) | ||
| cd_account = BMWConnectedDriveAccount(username, password, region, name) | ||
| cd_account = BMWConnectedDriveAccount(username, password, region, name,enable_services) |
There was a problem hiding this comment.
missing whitespace after ','
line too long (91 > 79 characters)
2 tasks
houndci-bot
reviewed
Aug 15, 2018
| enable_services = account_config[CONF_ENABLE_SERVICES] | ||
| _LOGGER.debug('Adding new account %s', name) | ||
| cd_account = BMWConnectedDriveAccount(username, password, region, name) | ||
| cd_account = BMWConnectedDriveAccount(username, password, region, name, enable_services) |
There was a problem hiding this comment.
line too long (92 > 79 characters)
houndci-bot
reviewed
Aug 15, 2018
| _LOGGER.debug('Adding new account %s', name) | ||
| cd_account = BMWConnectedDriveAccount(username, password, region, name) | ||
| cd_account = BMWConnectedDriveAccount(username, password, region, name, | ||
| enable_services) |
There was a problem hiding this comment.
continuation line under-indented for visual indent
houndci-bot
reviewed
Aug 15, 2018
| enable_services = account_config[CONF_ENABLE_SERVICES] | ||
| _LOGGER.debug('Adding new account %s', name) | ||
| cd_account = BMWConnectedDriveAccount(username, password, region, name) | ||
| cd_account = BMWConnectedDriveAccount(username, password, region, name, |
balloob
requested changes
Aug 16, 2018
|
|
||
| DOMAIN = 'bmw_connected_drive' | ||
| CONF_REGION = 'region' | ||
| CONF_ENABLE_SERVICES = 'services' |
Member
There was a problem hiding this comment.
Can you rename the option to read_only and default it to False
Contributor
Author
There was a problem hiding this comment.
do you mean CONF_READ_ONLY = 'services' ? This wouldnt make it consistent, because there is always a negation needed. I could do CONF_READ_ONLY = 'services_disabled' and set the default to false ?
Or CONF_READ_ONLY = 'read_only'
balloob
approved these changes
Aug 16, 2018
Merged
girlpunk
pushed a commit
to girlpunk/home-assistant
that referenced
this pull request
Sep 4, 2018
…5993) * Update __init__.py * Update bmw_connected_drive.py * Update __init__.py * Update bmw_connected_drive.py * Update __init__.py * Update __init__.py * Update __init__.py * Update __init__.py * Update __init__.py * Update __init__.py * Update __init__.py * Update bmw_connected_drive.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
I dont want to expose the services of my car to HA. The services"light turn on", "unlock" etc. should be disabled for security reasons. This PR adds an option to disable the services and lock
Related issue (if applicable): fixes #
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#6024
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: