Update bmw_connected_drive.markdown#6024
Merged
frenck merged 3 commits intohome-assistant:nextfrom Aug 17, 2018
Alexxander0:next
Merged
Update bmw_connected_drive.markdown#6024frenck merged 3 commits intohome-assistant:nextfrom Alexxander0:next
frenck merged 3 commits intohome-assistant:nextfrom
Alexxander0:next
Conversation
ghost
added
the
8 tasks
frenck
added
has-parent
Member
|
Hi there @Alexxander0! Thank you for this PR! Unfortunately, it is targeted against the wrong base. Since this is a new feature (implemented in your parent PR), it will be part of a next release, so it should go into the Please update the target branch and rebase if needed. |
tjorim
suggested changes
Aug 16, 2018
| services: | ||
| description: Enables or disables the services of the vehicles including the lock. Default true (Services enabled) | ||
| read_only: | ||
| description: Enables or disables the services of the vehicles including the lock. Default false (Services enabled) |
Contributor
There was a problem hiding this comment.
Please use the default: key to clarify what the default is -> documentation.
frenck
added
ready-for-review
frenck
approved these changes
Aug 17, 2018
Member
|
Thanks, @Alexxander0! 🏅 |
flo-wer
pushed a commit
to flo-wer/home-assistant.io
that referenced
this pull request
Aug 17, 2018
* Update bmw_connected_drive.markdown * Update bmw_connected_drive.markdown * Update bmw_connected_drive.markdown
flo-wer
pushed a commit
to flo-wer/home-assistant.io
that referenced
this pull request
Aug 17, 2018
* Update bmw_connected_drive.markdown * Update bmw_connected_drive.markdown * Update bmw_connected_drive.markdown
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Update of documentation of the BMW connected drive platform
Pull request in home-assistant (if applicable): home-assistant/core#15993
Checklist:
current. New documentation for platforms/components and features should go tonext.