Skip to content

Round values to only one decimal for Xiaomi Aqara sensors#11673

Merged
Danielhiversen merged 1 commit into
home-assistant:devfrom
covrig:dev
Jan 15, 2018
Merged

Round values to only one decimal for Xiaomi Aqara sensors#11673
Danielhiversen merged 1 commit into
home-assistant:devfrom
covrig:dev

Conversation

@covrig
Copy link
Copy Markdown
Contributor

@covrig covrig commented Jan 15, 2018

Description:

The manufactures states the accuracy below. For this reason two decimals is a bit too much and I kindly suggest to round the value to one decimal. This will also make the text a bit more visible in the top badges.
Temperature detection range: -20 - 60 Deg.C ( + / - 0.3 Deg.C )
Humidity detection range: 0 - 100pct RH ( + / - 0.3pct )
Atmospheric pressure detection range: 30 - 110KPa ( + / - 120Pa )

Checklist:

  • [x ] The code change is tested and works locally.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

Temperature detection range: -20 - 60 Deg.C ( + / - 0.3 Deg.C )
Humidity detection range: 0 - 100pct RH ( + / - 0.3pct )
Atmospheric pressure detection range: 30 - 110KPa ( + / - 120Pa )
@homeassistant
Copy link
Copy Markdown
Contributor

Hi @covrig,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@Danielhiversen
Copy link
Copy Markdown
Member

👍

@Danielhiversen Danielhiversen merged commit 5546ecd into home-assistant:dev Jan 15, 2018
@balloob balloob mentioned this pull request Jan 26, 2018
@home-assistant home-assistant locked and limited conversation to collaborators May 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants