Skip to content

Add nws weather.#9372

Merged
frenck merged 14 commits into
home-assistant:nextfrom
MatthewFlamm:nws
Sep 3, 2019
Merged

Add nws weather.#9372
frenck merged 14 commits into
home-assistant:nextfrom
MatthewFlamm:nws

Conversation

@MatthewFlamm
Copy link
Copy Markdown
Contributor

@MatthewFlamm MatthewFlamm commented May 3, 2019

Description:. Adds documentation for NWS Weather.

NWS requires permission to use their logo. How should this be done? Should I make this request? See NWS disclaimer page. I have commented out the logo line and have not included it yet.

Pull request in home-assistant (if applicable): home-assistant/core#23647

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@klaasnicolaas
Copy link
Copy Markdown
Member

Permission is not required to display unaltered NWS products which include the NWS name or NWS/NOAA visual identifier as part of the original product. Neither the name nor visual identifier may be used, however, in a manner that implies an endorsement or affiliation with NOAA/NWS.

@MatthewFlamm
Copy link
Copy Markdown
Contributor Author

@klaasnicolaas I'm not sure that we are using "unaltered NWS products" or " as part of the original product.". I would say it is minimally altered, does this meet this requirement?

@MatthewFlamm
Copy link
Copy Markdown
Contributor Author

You are right @klaasnicolaas. After reviewing this page, and in particular this section, I think our use is allowed. This addresses my concern about the minimal amount of altering we have done, as long as we explicitly only describe NWS/NOAA as being the data source.

  1. Question – How can I attribute the original source of the data I use to NWS or NOAA even if the display is not considered to be “unaltered?”

    Answer – You may, without requesting a license, attribute the source of the original data to NWS or NOAA as along as it is clearly indicated that the data are from NOAA/NWS and not the display (e.g., “Data source: NOAA”). In addition, as required by 17 U.S.C. 403, you cannot copyright the government content within your data/products.

The documentation in this PR follows this guidance in my opinion.

Since we need to align on naming between NOAA and NWS with #9458, I'm going to hold off on adding the logo at this time.

@frenck frenck added has-parent This PR has a parent PR in another repo new-integration This PR adds documentation for a new Home Assistant integration next This PR goes into the next branch ready-for-review This PR needs to be reviewed and removed to-do labels Jun 18, 2019
Comment thread source/_components/nws.markdown Outdated
Comment thread source/_components/nws.markdown Outdated
@klaasnicolaas klaasnicolaas added in-progress This PR/Issue is currently being worked on and removed ready-for-review This PR needs to be reviewed labels Jul 2, 2019
@MatthewFlamm
Copy link
Copy Markdown
Contributor Author

@klaasnicolaas Now that the backend PR will hopefully get some movement with a simplified structure, can we revisit the logo issue? I'm still not convinced that we fall under the specific requirements for no permission needed. I think we are very close to that line, but the language is very restrictive.

@frenck
Copy link
Copy Markdown
Member

frenck commented Jul 18, 2019

@MatthewFlamm Please leave it out. Thanks 👍

@MatthewFlamm
Copy link
Copy Markdown
Contributor Author

Thanks @frenck. I'm okay with this path forward for now. I do think we should consider asking permission if this integration gets included. I think our use is clearly within their acceptable use category, just not within the category where no permission is needed to use.

I will note here for completeness that noaatides integration already uses an NOAA logo, which is the umbrella organization of NWS, and has the same requirements for logo usage. I don't use this integration, so I cannot confirm, but it seems that this integration may be displaying the raw data without altering the data. So, my reading is that this would fall under the no permission needed category.

One tricky thing here is that if anyone else adds a new NOAA application that does not conform to this requirement, you may have to remove the logo at that point. Just pointing this out for future visibility.

Comment thread source/_components/nws.markdown Outdated
@MartinHjelmare MartinHjelmare added the parent-merged The parent PR has been merged already label Aug 23, 2019
@MatthewFlamm
Copy link
Copy Markdown
Contributor Author

I assumed this would go in 0.99 since 0.98 is in beta.

@klaasnicolaas
Copy link
Copy Markdown
Member

Yes thats correct

@klaasnicolaas
Copy link
Copy Markdown
Member

Can you update this PR with the latest changes from our upstream repo? Thnx 😄

@MatthewFlamm
Copy link
Copy Markdown
Contributor Author

Thanks, I saw the build error, but didn't have time to investigate right away.

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @MatthewFlamm! 👍

@frenck frenck dismissed klaasnicolaas’s stale review September 3, 2019 10:17

comments addressed

@frenck frenck merged commit fff5a10 into home-assistant:next Sep 3, 2019
@probot-home-assistant probot-home-assistant Bot removed in-progress This PR/Issue is currently being worked on parent-merged The parent PR has been merged already labels Sep 3, 2019
@MatthewFlamm MatthewFlamm deleted the nws branch September 3, 2019 10:55
@MatthewFlamm
Copy link
Copy Markdown
Contributor Author

Thanks @klaasnicolaas and @frenck!

@bbrendon bbrendon mentioned this pull request Sep 23, 2019
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-parent This PR has a parent PR in another repo new-integration This PR adds documentation for a new Home Assistant integration next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants