Add nws weather.#9372
Conversation
|
|
@klaasnicolaas I'm not sure that we are using "unaltered NWS products" or " as part of the original product.". I would say it is minimally altered, does this meet this requirement? |
|
You are right @klaasnicolaas. After reviewing this page, and in particular this section, I think our use is allowed. This addresses my concern about the minimal amount of altering we have done, as long as we explicitly only describe NWS/NOAA as being the data source.
The documentation in this PR follows this guidance in my opinion. Since we need to align on naming between NOAA and NWS with #9458, I'm going to hold off on adding the logo at this time. |
|
@klaasnicolaas Now that the backend PR will hopefully get some movement with a simplified structure, can we revisit the logo issue? I'm still not convinced that we fall under the specific requirements for no permission needed. I think we are very close to that line, but the language is very restrictive. |
|
@MatthewFlamm Please leave it out. Thanks 👍 |
|
Thanks @frenck. I'm okay with this path forward for now. I do think we should consider asking permission if this integration gets included. I think our use is clearly within their acceptable use category, just not within the category where no permission is needed to use. I will note here for completeness that noaatides integration already uses an NOAA logo, which is the umbrella organization of NWS, and has the same requirements for logo usage. I don't use this integration, so I cannot confirm, but it seems that this integration may be displaying the raw data without altering the data. So, my reading is that this would fall under the no permission needed category. One tricky thing here is that if anyone else adds a new NOAA application that does not conform to this requirement, you may have to remove the logo at that point. Just pointing this out for future visibility. |
|
I assumed this would go in 0.99 since 0.98 is in beta. |
|
Yes thats correct |
|
Can you update this PR with the latest changes from our upstream repo? Thnx 😄 |
Co-Authored-By: Klaas Schoute <klaas_schoute@hotmail.com>
It was requested in the backend PR to change the log level from INFO to DEBUG
|
Thanks, I saw the build error, but didn't have time to investigate right away. |
|
Thanks @klaasnicolaas and @frenck! |
Description:. Adds documentation for NWS Weather.
NWS requires permission to use their logo. How should this be done? Should I make this request? See NWS disclaimer page. I have commented out the logo line and have not included it yet.Pull request in home-assistant (if applicable): home-assistant/core#23647
Checklist:
nextis for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created againstcurrent.