Add homekit television#9186
Merged
Merged
Conversation
ghost
added
the
5 tasks
cdce8p
added
has-parent
albertleal
previously approved these changes
Apr 27, 2019
klaasnicolaas
added
ready-for-review
cdce8p
requested changes
Apr 30, 2019
Member
cdce8p
left a comment
cdce8p
left a comment
There was a problem hiding this comment.
Just a note to other reviewers that this PR still needs to be updated to reflect the changes made in the parent PR once those are finalized.
Member
|
Should we include a note that this feature requires |
klaasnicolaas
added
ready-for-review
Member
|
@cdce8p I would add that, avoids confusion. |
Member
|
I really like the changes you've done here. If you don't want to add anything else, I think this would be good to go. |
cdce8p
approved these changes
May 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
CC: @cdce8p
This adds the ability to expose
media_playerentities as Television types in HomeKit. This is an opt-in feature, requiring users with devices iOS 12.2 or later to change themedia_playerentity'sdevice_class: tv.I plan to add the ability to link a
remotelater on for additional functionality.Pull request in home-assistant (if applicable): home-assistant/core#22968
Checklist:
nextis for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created againstcurrent.