Clarifies expose_by_default and exposed_domains in google_assistant config#9008
Merged
frenck merged 1 commit intohome-assistant:currentfrom Mar 30, 2019
Merged
Clarifies expose_by_default and exposed_domains in google_assistant config#9008frenck merged 1 commit intohome-assistant:currentfrom
frenck merged 1 commit intohome-assistant:currentfrom
Conversation
ghost
added
the
klaasnicolaas
added
enhancement
ready-for-review
frenck
approved these changes
Mar 30, 2019
Member
|
Thanks, @dthulke! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Clarifies the documentation on the
expose_by_defaultandexposed_domainsconfig fields in the Google Assistant config.These have caused confusion among users in the past (see home-assistant/core#21577).
Ideally, the behaviour would be fixed in the code but this would break existing configs at least in some edge cases (see home-assistant/core#17745).
The proposed new description should explain the current behaviour of these options.
Checklist:
nextis for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created againstcurrent.