Skip to content

Genius hub#8815

Merged
klaasnicolaas merged 14 commits into
home-assistant:nextfrom
GeoffAtHome:genius-hub
Apr 18, 2019
Merged

Genius hub#8815
klaasnicolaas merged 14 commits into
home-assistant:nextfrom
GeoffAtHome:genius-hub

Conversation

@GeoffAtHome
Copy link
Copy Markdown
Contributor

@GeoffAtHome GeoffAtHome commented Mar 3, 2019 •
edited by frenck
Loading

Description:

Documentation for genius-hub.

Pull request in home-assistant (if applicable): home-assistant/core#21598

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@ghost ghost added the to-do label Mar 3, 2019
@GeoffAtHome
Copy link
Copy Markdown
Contributor Author

GeoffAtHome commented Mar 3, 2019

Added Genius Hub but how to I get the LightWave component merged? What do I need to do?

@GeoffAtHome GeoffAtHome mentioned this pull request Mar 4, 2019
Merged
1 task
@frenck frenck added new-integration This PR adds documentation for a new Home Assistant integration next This PR goes into the next branch has-parent This PR has a parent PR in another repo and removed to-do labels Mar 4, 2019
frenck
frenck previously requested changes Mar 4, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is not clean and contains PR's unrelated to this one. Please cleanup this branch.

@frenck frenck added the in-progress This PR/Issue is currently being worked on label Mar 4, 2019
@GeoffAtHome
Copy link
Copy Markdown
Contributor Author

GeoffAtHome commented Mar 4, 2019

@frenck @klaasnicolaas I am having trouble here. I feel the best way forward for me is to close this PR and open two different ones. One for Lightwave and the other for Genius hub. I am still trying to get to grips with Git.

Both should be fairly simple changes:
Lightwave needs to markdown updated to reflect the configuration settings.
Genius hub needs markdown and geniushub.png added.

Am I missing anything?

@GeoffAtHome
Copy link
Copy Markdown
Contributor Author

GeoffAtHome commented Mar 8, 2019

@frenck @klaasnicolaas anyone care to respond to my last question? Should I close this PR and raise two new ones?

@frenck
Copy link
Copy Markdown
Member

frenck commented Mar 11, 2019

@GeoffAtHome The lightwave changes aren't related to the Genius hub? Right?
In that case, it should have been separate PR's.

@GeoffAtHome
Copy link
Copy Markdown
Contributor Author

GeoffAtHome commented Mar 14, 2019

@frenck I am still confused. You say 'it should have been separate PR's'. Does this mean I should close this PR and raise two new ones or is what is presented here good enough?

@klaasnicolaas
Copy link
Copy Markdown
Member

klaasnicolaas commented Mar 14, 2019

In the case of this PR you only have to remove the lightwave adjustments, because they have nothing to do with the genius hub.

@GeoffAtHome
Copy link
Copy Markdown
Contributor Author

GeoffAtHome commented Mar 18, 2019

@klaasnicolaas Lightwave changes removed. Will resubmit these at a later date on another PR.

@zxdavb
Copy link
Copy Markdown
Member

zxdavb commented Apr 16, 2019

This PR is not clean and contains PR's unrelated to this one. Please cleanup this branch.

@frenck I have addressed the issue as you requested.

MartinHjelmare
MartinHjelmare reviewed Apr 16, 2019
View reviewed changes
Comment thread source/_components/geniushub.markdown Outdated
Comment thread source/_components/geniushub.markdown Outdated
Comment thread source/_components/geniushub.markdown Outdated
@zxdavb zxdavb mentioned this pull request Apr 17, 2019
Merged
10 tasks
MartinHjelmare
MartinHjelmare previously approved these changes Apr 18, 2019
View reviewed changes
@klaasnicolaas
✏️ Tweak
24d5524 
After this commit we can merge it and add it to the milestone
@klaasnicolaas klaasnicolaas added parent-merged The parent PR has been merged already and removed in-progress This PR/Issue is currently being worked on labels Apr 18, 2019
@klaasnicolaas klaasnicolaas added this to the 0.92.0 milestone Apr 18, 2019
@klaasnicolaas klaasnicolaas dismissed frenck’s stale review April 18, 2019 14:07

The PR is clean now

@klaasnicolaas klaasnicolaas merged commit 4096ef3 into home-assistant:next Apr 18, 2019
@klaasnicolaas
Copy link
Copy Markdown
Member

klaasnicolaas commented Apr 18, 2019 •
edited
Loading

Thnx for the PR! 👍 @GeoffAtHome

@balloob balloob added the cherry-picked This PR has been manually picked and merged into the current branch label Apr 24, 2019
balloob pushed a commit that referenced this pull request Apr 24, 2019
@GeoffAtHome @balloob
Genius hub (#8815)
1223770 
* Manual registration/de-registration support.

* Move registration/de-registration to a service.

* 🔨 Move it to the right direction

- Added variable configuration
- Fixed the example script and split it

* Added Genius Hub

* Revert lightwvave changes.

* Update markdown

* fix a small bug

* ✏️ Tweak

* token: and host: now separate

* ✏️ Tweak

After this commit we can merge it and add it to the milestone

* ✏️ Tweak

* ✏️ Make urls clickable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zxdavb zxdavb zxdavb left review comments

@klaasnicolaas klaasnicolaas klaasnicolaas approved these changes

@frenck frenck frenck left review comments

@MartinHjelmare MartinHjelmare MartinHjelmare left review comments

Assignees

@GeoffAtHome GeoffAtHome

Labels

cherry-picked This PR has been manually picked and merged into the current branch has-parent This PR has a parent PR in another repo new-integration This PR adds documentation for a new Home Assistant integration next This PR goes into the next branch parent-merged The parent PR has been merged already

Projects

None yet

Milestone

0.92.0

Development

Successfully merging this pull request may close these issues.

6 participants

@GeoffAtHome @frenck @klaasnicolaas @zxdavb @MartinHjelmare @balloob