Skip to content

Add example of choice of sources for Person#8779

Merged
balloob merged 8 commits into
home-assistant:nextfrom
gorynychzmey:patch-1
Mar 5, 2019
Merged

Add example of choice of sources for Person#8779
balloob merged 8 commits into
home-assistant:nextfrom
gorynychzmey:patch-1

Conversation

@gorynychzmey
Copy link
Copy Markdown
Contributor

@gorynychzmey gorynychzmey commented Feb 28, 2019

Description:

Added example of choice sources for Person.

Pull request in home-assistant (if applicable): home-assistant/home-assistant#

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@ghost ghost added the to-do label Feb 28, 2019
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update and examples!

Comment thread source/_components/person.markdown Outdated

Lets say for example, that you have 3 trackers: 'tracker_gps', 'tracker_router' and 'tracker_ble'.

1. You're at home, all 3 devices shows status 'home' - status of your Person entity will be 'home' with source 'tracker_gps'.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this case use tracker_router or tracker_ble as source, since those are non gps?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, exactly! Thanks, I've corrected this.

@MartinHjelmare MartinHjelmare changed the title Added example of choice sources for Person Add example of choice of sources for Person Feb 28, 2019
MartinHjelmare
MartinHjelmare previously approved these changes Feb 28, 2019
@klaasnicolaas klaasnicolaas added new-feature This PR adds documentation for a new Home Assistant feature to an existing integration ready-for-review This PR needs to be reviewed next This PR goes into the next branch has-parent This PR has a parent PR in another repo parent-merged The parent PR has been merged already and removed to-do labels Feb 28, 2019
@balloob balloob added this to the 0.89.0 milestone Feb 28, 2019
@balloob balloob merged commit ae3f96f into home-assistant:next Mar 5, 2019
@ghost ghost removed the ready-for-review This PR needs to be reviewed label Mar 5, 2019
@balloob balloob added the cherry-picked This PR has been manually picked and merged into the current branch label Mar 5, 2019
balloob pushed a commit that referenced this pull request Mar 5, 2019
* Added description for source priority.

* Changed description of source priority.

* Added example of sources' choice.

* Corrected example

* Added TL;DR to example

* Updated TL:DR

* Added hint for consider_home
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-picked This PR has been manually picked and merged into the current branch has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch parent-merged The parent PR has been merged already

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants