Skip to content

Document 'firetv.adb_command' service#8722

Merged
rohankapoorcom merged 5 commits into
home-assistant:nextfrom
JeffLIrion:next
Mar 4, 2019
Merged

Document 'firetv.adb_command' service#8722
rohankapoorcom merged 5 commits into
home-assistant:nextfrom
JeffLIrion:next

Conversation

@JeffLIrion
Copy link
Copy Markdown
Contributor

@JeffLIrion JeffLIrion commented Feb 24, 2019

Description:

Documentation for the media_player.firetv_adb_cmd service.

Generated documentation: https://deploy-preview-8722--home-assistant-docs.netlify.com/components/media_player.firetv/

Pull request in home-assistant (if applicable): home-assistant/core#21419

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@JeffLIrion JeffLIrion changed the title Document 'media_player.firetv_adb_cmd' service Document 'media_player.firetv_adb_command' service Feb 25, 2019
@frenck frenck added new-feature This PR adds documentation for a new Home Assistant feature to an existing integration ready-for-review This PR needs to be reviewed next This PR goes into the next branch has-parent This PR has a parent PR in another repo and removed to-do labels Feb 25, 2019
@JeffLIrion
Copy link
Copy Markdown
Contributor Author

Does media_player.firetv.markdown need to be renamed, maybe to firetv.markdown or firetv.media_player.markdown?

@MartinHjelmare
Copy link
Copy Markdown
Member

@fabaff should we move the page, since the platform has moved to embedded under the firetv component package? The configuration hasn't changed.

@frenck frenck added the parent-merged The parent PR has been merged already label Mar 1, 2019
@JeffLIrion JeffLIrion changed the title Document 'media_player.firetv_adb_command' service Document 'firetv.adb_command' service Mar 1, 2019
@JeffLIrion
Copy link
Copy Markdown
Contributor Author

Any consensus on whether this file should be renamed? The documentation website builds just fine, so renaming this file could always be done later.

Copy link
Copy Markdown
Member

@rohankapoorcom rohankapoorcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes requested to match style guidelines.

Comment thread source/_components/media_player.firetv.markdown
Comment thread source/_components/media_player.firetv.markdown Outdated
@rohankapoorcom
Copy link
Copy Markdown
Member

Thanks! I'm going to go ahead and merge this in since there's more changes coming to this file (#8806). If it needs to be renamed, we can handle it elsewhere.

@rohankapoorcom rohankapoorcom merged commit e45c497 into home-assistant:next Mar 4, 2019
@ghost ghost removed the ready-for-review This PR needs to be reviewed label Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch parent-merged The parent PR has been merged already

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants