Clarify that http.base_url doesn't support paths#8615
Merged
Conversation
Explains that paths aren't supported in base_url so someone attempting to set settings doesn't expect something that isn't currently possible. Related: home-assistant/core#21113
ghost
added
the
klaasnicolaas
added
enhancement
ready-for-review
davidjb
added a commit
to davidjb/home-assistant.io
that referenced
this pull request
Mar 29, 2019
Improves on the wording of my previous PR for readability
davidjb
added a commit
to davidjb/home-assistant.io
that referenced
this pull request
Mar 29, 2019
Improves on the wording of my previous PR for readability
2 tasks
frenck
pushed a commit
that referenced
this pull request
Mar 30, 2019
|
2021-07-13 12:24:09 WARNING (MainThread) [homeassistant.components.http] The 'base_url' option is deprecated, please remove it from your configuration hass behind revert proxy (nginx) need requests uri relative, and also this is a better practice develop web app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Explain that paths aren't supported in the
http.base_urlsetting to clarify expectations about this option. The termbase_urlimplied that this option could be a URL but in fact it may only currently be part of a URL.Related: home-assistant/core#21113
Pull request in home-assistant (if applicable): N/A
Checklist:
nextis for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created againstcurrent.